-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename .vcApiTestImplementationsConfig.cjs
to .localImplementationsConfig.cjs
.
#98
Conversation
`localImplementationsConfig.cjs`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is hard, but this one is definitely better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change, actually.
CHANGELOG.md
Outdated
|
||
### Changed | ||
- **BREAKING**: Rename `vcApiTestImplementationsConfig.cjs` config for testing | ||
localhost implementations to `localImplementationsConfig.cjs`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These both need .
prefixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BigBlueHat Good catch, thanks! Fixed here 6d1fae3
vcApiTestImplementationsConfig.cjs
to localImplementationsConfig.cjs
..vcApiTestImplementationsConfig.cjs
to .localImplementationsConfig.cjs
.
No description provided.